Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Integrated logs for aspnet and wilson #331

Closed
tushargupta51 opened this issue Jul 2, 2015 · 8 comments
Closed

Integrated logs for aspnet and wilson #331

tushargupta51 opened this issue Jul 2, 2015 · 8 comments
Labels

Comments

@tushargupta51
Copy link
Contributor

Microsoft.Aspnet.Authentication.OpenIdConnect uses ILogger to log events whereas Wilson uses EventSource based logging. Currently, there is no easy way for a user using OIDC to get an integrated log from both aspnet and wilson (OIDC takes a hard dependency on Wilson). They have to configure both the loggers separately and it is very difficult to debug using the separated logs.

@leastprivilege
Copy link
Contributor

Oh really - why is that? Must be an artifact from the Katana version.

@kevinchalet
Copy link
Contributor

@leastprivilege ILogger is part of the new logging block and has nothing to do with Katana: https://github.com/aspnet/Logging 😄

@leastprivilege
Copy link
Contributor

Oh really? ;) So who is using EventSource then - and why?

@kevinchalet
Copy link
Contributor

EventSource is used by Wilson for its internal logging.

Why? I dunno: #258 (comment)

@brentschmaltz
Copy link
Contributor

Because ILogger is not available for some of the customers of Wilson.

@kevinchalet
Copy link
Contributor

Then it might be a good idea to list those targets and add them to aspnet/Logger.

/cc @Eilon

@tushargupta51
Copy link
Contributor Author

Aligning the logging experience of Wilson with ADAL is one reason. ADAL uses EventSource.

@Eilon
Copy link
Member

Eilon commented Sep 3, 2015

Both ASP.NET 5 components and Wilson can (or will be able to) write to EventSource, and that is the best way to get unified logs.

@Eilon Eilon closed this as completed Sep 3, 2015
@Eilon Eilon added the wontfix label Sep 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants