Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Update the OAuth2 handler to log error_description and error_uri when receiving an error #512

Closed
kevinchalet opened this issue Oct 9, 2015 · 3 comments
Assignees
Milestone

Comments

@kevinchalet
Copy link
Contributor

#495 (comment)

FYI: the OIDC handler already does that: https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenIdConnectHandler.cs#L382-L383

@brentschmaltz
Copy link
Contributor

As long as the handler is sure the message is for itself this is fine, otherwise handlers will get in each others face. I have seen handlers where the param 'f' => failure.

@kevinchalet
Copy link
Contributor Author

@brentschmaltz no risk: unlike the OIDC middleware (though it may change in the future: #455), the OAuth2 base middleware only listens on its own callback path, so unless you use the same one for multiple handlers, you shouldn't see any issue 👍

@Eilon Eilon added this to the 1.0.0-rc1 milestone Oct 15, 2015
@muratg muratg modified the milestones: 1.0.0-rc2, 1.0.0-rc1 Oct 22, 2015
@HaoK HaoK self-assigned this Nov 12, 2015
@HaoK
Copy link
Member

HaoK commented Nov 19, 2015

620622f

@HaoK HaoK closed this as completed Nov 19, 2015
@HaoK HaoK added 3 - Done and removed 2 - Working labels Nov 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants