Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

InvokeGroupAsync #525

Closed
grahamehorner opened this issue Jun 6, 2017 · 4 comments
Closed

InvokeGroupAsync #525

grahamehorner opened this issue Jun 6, 2017 · 4 comments

Comments

@grahamehorner
Copy link

the current implementation of DefaultHubLifetimeManager.InvokeGroupAsync scans each connections metadata in the in the hope of find a connection with a matching group; this would result in wasteful resources when a name of a group that is not used/or has no connection is supplied, IMHO the default implementation should have an index of group names with a count of active connections to prevent this especially when a hub could have many connections.

@davidfowl
Copy link
Member

Yes we're going to do this eventually. None of the stack is optimized right right. We're working towards an MVP before we do any of that work. #394

@grahamehorner
Copy link
Author

@davidfowl happy to start they ball rolling with a proof of concept if that would help?

@moozzyk moozzyk added this to the 2.1.0 milestone Jun 9, 2017
@davidfowl
Copy link
Member

Sure

@mikaelm12
Copy link
Contributor

This has been addressed in af286c8
Thanks @Gurgen !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants