Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 8 #5431

Closed
danroth27 opened this issue Aug 21, 2018 · 15 comments
Closed

Update to Angular 8 #5431

danroth27 opened this issue Aug 21, 2018 · 15 comments
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@danroth27
Copy link
Member

It looks like Angular 7 is scheduled to be released in Sept/Oct of this year: https://angular.io/guide/releases#release-schedule

@Korigoth
Copy link

any ETA for this ?

@nokturnal
Copy link

Also waiting for this, a rough ETA would be appreciated

@Korigoth
Copy link

Korigoth commented Dec 4, 2018

@nokturnal it seems it will be released with DotNetCore 3.0 as we see it's in the preview atm

@nokturnal
Copy link

@Korigoth though not ideal, I appreciate the feedback. Thanks

@aspnet-hello aspnet-hello transferred this issue from aspnet/Templating Dec 17, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0-preview2 milestone Dec 17, 2018
@aspnet-hello aspnet-hello added 1 - Ready area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Dec 17, 2018
@blogcraft
Copy link

The problem is that March/April 2019 will be the release of Angular 8.

It seems you are always 1 version behind.

@stephenlautier
Copy link
Contributor

With the current template (on .net 2.2) I got it working with Angular7 + SSR.

The only thing I can't get working for SSR is optimization or bundling together (both on server), if I enable one of them it works, together they don't (cause i don't want to copy all node_modules for SSR).

NOTE

  • I had to do several changes/fixes in order to get SSR workin (even for Angular 6)

SSR Error with optimization + bundling

An unhandled exception occurred while processing the request.
NodeInvocationException: StaticInjectorError[InjectionToken Application Initializer -> InjectionToken DocumentToken]: 
StaticInjectorError(Platform: core)[InjectionToken Application Initializer -> InjectionToken DocumentToken]: 
Right-hand side of 'instanceof' is not an object
TypeError: StaticInjectorError[InjectionToken Application Initializer -> InjectionToken DocumentToken]: 
StaticInjectorError(Platform: core)[InjectionToken Application Initializer -> InjectionToken DocumentToken]: 
Right-hand side of 'instanceof' is not an object
at insertElement (C:\dev\git\Cosmowrench\Sketch7.Cosmowrench\ClientApp\dist-server\main.js:1:2597704)
at insertHTMLElement (C:\dev\git\Cosmowrench\Sketch7.Cosmowrench\ClientApp\dist-server\main.js:1:2597428)
at before_head_mode (C:\dev\git\Cosmowrench\Sketch7.Cosmowrench\ClientApp\dist-server\main.js:1:2635408)
at HTMLParser.htmlparser.insertToken (C:\dev\git\Cosmowrench\Sketch7.Cosmowrench\ClientApp\dist-server\main.js:1:2596464)

@stephenlautier
Copy link
Contributor

Just if anyone wants to see the repo, feel free to check it out on

https://github.com/sketch7/dotnet-ngx-sample ❤️

@mkArtakMSFT
Copy link
Member

Looks like Angular 8 is going to be released before 3.0 ships, so we'll wait for that instead and skip update to Angular 7.
I'm updating the title to reuse this issue for that purpose.

@mkArtakMSFT mkArtakMSFT changed the title Update to Angular 7 Update to Angular 8 Feb 25, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview6, Backlog Apr 19, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: Backlog, 3.0.0-preview7 May 10, 2019
@varghesep
Copy link

varghesep commented May 19, 2019

I manually upgraded the angular app that runs under asp.net core 2.2 to 8.0 Preview. One major problem that I came across was that the app generates an error related to SSL quite often in Chrome, but not on edge. I posted a question in stackoverflow regarding this.

@isaacrlevin
Copy link
Contributor

Looks like Angular 8 was released end of May, I can add it

@mkArtakMSFT mkArtakMSFT added the blocked The work on this issue is blocked due to some dependency label Jun 17, 2019
@mkArtakMSFT
Copy link
Member

Moving this to preview 8, as we're blocked on security review.

@ngohungphuc
Copy link

Is ther any update on my PR #10616 ?

@mkArtakMSFT
Copy link
Member

@ngohungphuc we're working through some security-related aspects of this, before we can take it.

@ryanbrandenburg ryanbrandenburg removed the blocked The work on this issue is blocked due to some dependency label Jul 1, 2019
ryanbrandenburg added a commit that referenced this issue Jul 2, 2019
Updated Angular from 7.2.5 to 8.0 using ng update #5431
@ryanbrandenburg ryanbrandenburg added Done This issue has been fixed and removed Working labels Jul 2, 2019
@blogcraft
Copy link

... And what about Angular 9 with Ivy?

@danroth27
Copy link
Member Author

And what about Angular 9 with Ivy?

@blogcraft #14076

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests