New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

are acquisition function inputs scaled? #2

Open

rmacknight99 opened this issue Feb 20, 2024 · 0 comments

rmacknight99 commented Feb 20, 2024

atlas/src/atlas/acquisition_optimizers/genetic_optimizer.py

Line 185 in a9cbbb7

def acquisition(self, x: np.ndarray) -> Tuple:

Investigating this method for the genetic optimizer seems to suggest the input is not scaled, is something like this neccesary?

x = torch.tensor(
            forward_normalize(
                self.deindexify(x.reshape((1, x.shape[0]))), 
                self.params_obj._mins_x, 
                self.params_obj._maxs_x
            )
        )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment