Skip to content
This repository has been archived by the owner on Dec 16, 2023. It is now read-only.

request occasionally fires multiple end events #120

Open
justincy opened this issue Aug 15, 2016 · 0 comments
Open

request occasionally fires multiple end events #120

justincy opened this issue Aug 15, 2016 · 0 comments

Comments

@justincy
Copy link

justincy commented Aug 15, 2016

When using request the end events are sometimes fired multiple times. This is because request includes a fix for a bug in node core. request will fire an end when it see a close event if it hasn't yet seen an end event. Sometimes request is receiving the close event from node-replay first which causes it to fire an end event and then request receives the end event from node-replay and fires another end event.

A quick fix is disabling these lines of code but I don't know if that would have any unintended consequences.

I believe it only occurs on some requests because it's a race condition.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant