Skip to content
This repository has been archived by the owner on Dec 16, 2023. It is now read-only.

regex in catalog.js chokes on CRLF replay files when .slice() invoked #153

Open
ggb667 opened this issue May 23, 2018 · 1 comment
Open

Comments

@ggb667
Copy link

ggb667 commented May 23, 2018

I know its GIT screwing these up, but headers are defined as CRLF in the standard, so the file ought to be able to handle either format. But it does not. This leads to people checking things out and tests failing that ran locally and run on the remote jenkins, but fail locally.

Sometimes you get a warning that the method .slice() was invoked on null, if you are in a debugger, but when running mocha from the command like you get an unhelpful message:

(node:11932) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: POST http://uso12degx03:3051/ refused: not recording and no network access

It was choking on the first value "accept: text/xml" when it tried to match ^(.?):\s+(.)$

Line 59 (and others if you fix this one).
var _line$match$slice = line.match(/^(.?):\s+(.)$/).slice(1),

line.match(/^(.?):\s+(.)$/) is null so the method invocation explodes.

Work around:

  1. Add to a .gitattributes file
    /**/replay* text eol=lf

  2. Change the files to LF

  3. Run
    git config --global core.autocrlf input

@ggb667 ggb667 changed the title /.split regex in catalog.js chokes on CRLF replay files regex in catalog.js chokes on CRLF replay files when .slice() invoked May 23, 2018
@ggb667
Copy link
Author

ggb667 commented May 30, 2018

Temporary work around:

Without a proper .gitattributes file (e.g. /**/replay* text eol=lf), or if generated and/or edited without .gitconfig being set properly (e.g. git config --global core.autocrlf input) they will fail when tests are run locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant