feat(trycmd): Support echo text | command
#344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
force-pushed
the
echo-int-trycmd
branch
2 times, most recently
from
c9bf8cd to
eb1af6f
Compare
|
A test is included. In the project I'm using it in, switching from the published to the git version correctly shows that my README.md (which was ignored so far) is subtly lying, which is factually the correct result. |
|
Thank you for your interest in this! However, I feel it is premature to have a PR for this as we have not decided on a solution and solution discussions I feel are best left to issues. I have also found the existence of PRs are manipulative of maintainers, whether intended by the author or not, as maintainers want to honor the work that was done by people and work to merge it. Some maintainers recognize that and learn to not care at all. For myself, I've taken a fairly hard stance that I push back and close PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than attempting to do the common case and facing its security implications, this uses the fact that echo is defined in POSIX with a very small feature set, and that piping is a simple shell feature. The presence of the
echocommand is recognized (as any shell might recognize it) and evaluated into stdin data.Closes: #172 (thus CC'ing @jpmckinney)
[edit: Add POSIX link]