Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Http Retry] Impossible to see response body from 5xx responses #268

Closed
joepkalthoff opened this issue Sep 4, 2024 · 4 comments · Fixed by #273
Closed

[Http Retry] Impossible to see response body from 5xx responses #268

joepkalthoff opened this issue Sep 4, 2024 · 4 comments · Fixed by #273
Assignees
Labels
Milestone

Comments

@joepkalthoff
Copy link

joepkalthoff commented Sep 4, 2024

Summary

You can't find the response body from 5xx responses in the Flow Manager Logs or Transactions of a flow .

Testcase

Dovetail version: 4.17.0-SNAPSHOT-dcb7cc8
Instance: next
Tenant: Regression Tests

Sending Flow: HttpRetrySocketAsynchronous
Flow version: 7
url: https://next.dovetail.world/flowdesigner/66b1efbde56ba4001000012e/7/route

Receiving Flow: HttpRetry500
Flow version: 1
url: https://next.dovetail.world/flowdesigner/66b31c0ee56ba4000e00002f/1/route

Input:

Output:
Check the Logs and Transactions of the Receiving flow. Try to find the response body of the 5xx statuscode responses that trigger the retry.

Result

Below you see the last response from the Receiving flow in the transactions of the Sending flow. Notice the response body. After the second retry the Receiving flow responds with a 200 statuscode and a response body.
Image

But the 5xx responses also had a body defined that you can't see / evaluate anywhere in the Flow Manager details:
Image

Conclusion

There should be a way to see the response body of 5xx responses. The response body can contain valuable information about why the server responded with a 5xx statuscode. This gives the user a chance to fix underlying issues that cause the 5xx response in the first place.

Maybe we should create an entry in the Logs of the flow for showing the headers and body for each 5xx response?

This issue is related to the response headers that interfere with the retry messages, that is documented in a seperate issue: #269.

Original issue on Dovetail Application board: https://github.com/dovetailworld/front-end/issues/4636.

@skin27
Copy link
Member

skin27 commented Sep 13, 2024

There is already a mechanism that logs all relevant information. I assume this isn't probably referenced to the correct flow, so that it's not in log of the flow (only in the general log on the server). We will investigate this.

@joepkalthoff
Copy link
Author

joepkalthoff commented Oct 1, 2024

Where am I supposed to see the response body?

EDIT: After meet with Raymond it seems that the HTTP response code and response body are not correctly shown in the 'warning' log entry:

HTTP Status: NOSTATUSCODE | Flow: 66fbc81334b996002200028b | API Endpoint: https://development.dovetail.world/test/inbound_http/regressiontests/HttpRetry500 | Retry in 10000 milliseconds | Attempt 2 | Body: {"name":"value"} | Exception: MISSING1? | ResponseText: MISSING2?

Body in the entry above is the original body, not the response body. I'm not sure if the response body should be shown there or after ResponseText: in MISSING2?.

Also not sure if the exceptionn is expected in MISSING1?

@Hooghof Hooghof reopened this Oct 2, 2024
@brunovg
Copy link
Collaborator

brunovg commented Oct 7, 2024

@brunovg brunovg closed this as completed Oct 7, 2024
@joepkalthoff
Copy link
Author

Tested and response in log WARN entry is complete now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants