Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all DeprecationWarning from within tabulate #3

Closed
ssbarnea opened this issue Sep 24, 2019 · 2 comments
Closed

Fix all DeprecationWarning from within tabulate #3

ssbarnea opened this issue Sep 24, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ssbarnea
Copy link
Contributor

@astanin I salute the move from bitbucket to git and github as it makes the project clearly more accesible (and easier to contribute back).

I have a strong interest in keeping tabulate maintained because I use it in https://github.com/ansible/molecule/ and currently I am facing deprecation warning from inside tabulate. Unless tabulate regains its maintenance status, I will be forced to either looks for a replacement or to even fork it. Example tabulate.py:1258: DeprecationWarning: invalid escape sequence \e -- which probably was fixed in master but without are pypi release that is of no help.

If you need help with maintenance, especially CI, packaging, release, let me know. BTW, it would be a good idea to move the repository under an organization so it would not be dependent only on you. For example I am using https://github.com/pycontribs/ for lots of projects and ensure that projects do not have a single human point of failure ;)

@astanin
Copy link
Owner

astanin commented Sep 25, 2019

@ssbarnea Thanks for offering help. I intend to take care of the project, but do not plan to add major features, and cannot dedicate much time to it at the moment. Pull requests that fix compatibility issues are welcome.

Yes, I could use some help in setting up CI, fixing packaging etc. In particular, the new github repo has yet to be setup properly.

I have just uploaded the latest version to PyPI. It took me a while to figure out how to build sdist so it passes twine checks (PyPI docs and error messages were not very helpful). Now the issue is solved and the future updates should come online quicker.

0.8.4 should fix the old Deprecated warning regarding importing ABCs from collections (bitbucket issue 157). The other issue reported by you (bitbucket issue 174) still has to be fixed. Feel free to provide a fix.

https://bitbucket.org/astanin/python-tabulate/issues/157/deprecationwarning-when-running-under-37
https://bitbucket.org/astanin/python-tabulate/issues/174/invalid-escape-sequence

@astanin astanin changed the title project maintenance and new release python tabulate release 0.8.4 Sep 25, 2019
@ssbarnea
Copy link
Contributor Author

Please look at PR above and feel free to cherry pick it, is so big because the was not not previously linted (and the linter would have spotted these issues).

@ssbarnea ssbarnea changed the title python tabulate release 0.8.4 Fix all DeprecationWarning from within tabulate Sep 25, 2019
@astanin astanin added the enhancement New feature or request label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants