-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsets should always be considered successful #640
Comments
rbino
changed the title
Unsets should be always considered successful
Unsets should always be considered successful
Feb 7, 2022
Closed by #691. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is related to #438, which fixed this for properties setting but didn't fix it for properties unset. For the same reason, unsets should always return
200 OK
regardless of the number of matches on the broker because:/control/consumerProperties
message.Incidentally, there's currently another bug because the unset gets saved in the database before checking the return value of
ensure_unset
, but this was not put in a separate issue because after this issue is fixedensure_unset
will always succeed by construction, thus making it always valid to save the value to the DB before it is sent.Reported by @szakhlypa
The text was updated successfully, but these errors were encountered: