Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance VirtualDevicePool #14

Open
2 tasks done
rbino opened this issue Feb 12, 2020 · 2 comments
Open
2 tasks done

Enhance VirtualDevicePool #14

rbino opened this issue Feb 12, 2020 · 2 comments
Labels
discussion This issue needs to be investigated/discussed (it might be already fixed, invalid or duplicated) main feature This issue or pull request is about a main scheduled feature

Comments

@rbino
Copy link
Contributor

rbino commented Feb 12, 2020

  • Allow passing interfaces in the configuration instead of loading them from disk
  • Allow dynamic registration of new devices

Open discussion point: where do we store the credential secret of newly registered devices?

@rbino rbino added discussion This issue needs to be investigated/discussed (it might be already fixed, invalid or duplicated) main feature This issue or pull request is about a main scheduled feature labels Feb 12, 2020
@drf
Copy link
Contributor

drf commented Feb 12, 2020

Open discussion point: where do we store the credential secret of newly registered devices?

Do we even need to do that? In my mind, if a Device is declared as a Virtual Device, it should be denied access from any transport and go straight into DUP queues. I reckon this might pose a limitation to a Device being tied to a single Flow (but maybe this can be circumvented somehow? Or do we assume that 2nd steps on a Virtual Device would be done through Flow interfaces, which kind of makes sense?), but preventing usage of a Virtual Device from outside Flow itself seems like the most logical solution to me.

@rbino
Copy link
Contributor Author

rbino commented Feb 13, 2020

Your point is totally valid, but we still have to support the Edge case, which implies the standard registration mechanism since we can't access in-cluster Rabbit queues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue needs to be investigated/discussed (it might be already fixed, invalid or duplicated) main feature This issue or pull request is about a main scheduled feature
Projects
None yet
Development

No branches or pull requests

2 participants