-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAAPI filtering #112
Comments
From a little more digging it looks like what is actually missing is the ability to call |
@asticode I'm open to opening an PR adding this functionality but i'm not sure quite what shape you'd want the API to take. This buffer parameters type is an unusual one. |
I'm really looking to add this to |
The fftools code is the only example I'm aware of. To be honest I think in all likelihood adding access to this parameters API for buffersrc might be enough to do the job. Hardware decoding from your example already works and when hardware frames are passed to the filter there's an error that If it doesn't work then it building a full c version is probably the only way. |
I'll be honest, until I understand properly how it should work it's hard to come up with the best API for |
The
FilterContext
type is missing some accessors required to make it able to do hardware filtering with filters likescale_vaapi
The
transcode_vaapi.c
example in the ffmpeg repo covers the mechanism pretty well, I think something as simple as addingSetHardwareFrameContext
toFilterContext
might make this possible.The text was updated successfully, but these errors were encountered: