Skip to content

Commit 33933a8

Browse files
committed
Use local salsa
1 parent 0a7ce81 commit 33933a8

File tree

7 files changed

+35
-18
lines changed

7 files changed

+35
-18
lines changed

Cargo.lock

Lines changed: 23 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ regex = { version = "1.10.2" }
129129
rustc-hash = { version = "2.0.0" }
130130
rustc-stable-hash = { version = "0.1.2" }
131131
# When updating salsa, make sure to also update the revision in `fuzz/Cargo.toml`
132-
salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "9f7fa33789ec524a66eab8e8ab6a3a0bec3c0bb5" }
132+
salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "d980b9e532edbd0ff8570f8c467f8f0a5f3f97e7" }
133133
schemars = { version = "0.8.16" }
134134
seahash = { version = "4.1.0" }
135135
serde = { version = "1.0.197", features = ["derive"] }

crates/ruff_db/src/testing.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ pub fn assert_function_query_was_not_run<Db, Q, QDb, I, R>(
1313
Q: Fn(QDb, I) -> R,
1414
I: salsa::plumbing::AsId + std::fmt::Debug + Copy,
1515
{
16-
let id = input.as_id().as_u32();
16+
let id = input.as_id();
1717
let (query_name, will_execute_event) = find_will_execute_event(db, query, input, events);
1818

1919
db.attach(|_| {
2020
if let Some(will_execute_event) = will_execute_event {
21-
panic!("Expected query {query_name}({id}) not to have run but it did: {will_execute_event:?}\n\n{events:#?}");
21+
panic!("Expected query {query_name}({id:?}) not to have run but it did: {will_execute_event:?}\n\n{events:#?}");
2222
}
2323
});
2424
}
@@ -65,7 +65,7 @@ pub fn assert_function_query_was_run<Db, Q, QDb, I, R>(
6565
Q: Fn(QDb, I) -> R,
6666
I: salsa::plumbing::AsId + std::fmt::Debug + Copy,
6767
{
68-
let id = input.as_id().as_u32();
68+
let id = input.as_id();
6969
let (query_name, will_execute_event) = find_will_execute_event(db, query, input, events);
7070

7171
db.attach(|_| {

crates/ty_python_semantic/resources/primer/bad.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,24 @@ artigraph # cycle panics (value_type_)
44
arviz # too many iterations on versions of arviz newer than https://github.com/arviz-devs/arviz/commit/3205b82bb4d6097c31f7334d7ac51a6de37002d0
55
core # cycle panics (value_type_)
66
cpython # access to field whilst being initialized, too many cycle iterations
7-
discord.py # some kind of hang, only when multi-threaded?
8-
freqtrade # hangs
7+
discord.py
8+
freqtrade
99
hydpy # too many iterations
1010
ibis # too many iterations
1111
jax # too many iterations
1212
packaging # too many iterations
1313
pandas # slow
14-
pandas-stubs # hangs/slow, or else https://github.com/salsa-rs/salsa/issues/831
14+
pandas-stubs # hangs (sometimes) with 7 or more threads
1515
pandera # stack overflow
1616
pip # vendors packaging, see above
17-
prefect # slow
17+
prefect
1818
pylint # cycle panics (self-recursive type alias)
1919
pyodide # too many cycle iterations
2020
pywin32 # bad use-def map (binding with definitely-visible unbound)
21-
schemathesis # https://github.com/salsa-rs/salsa/issues/831
21+
schemathesis
2222
scikit-learn # success, but mypy-primer hangs processing the output
2323
setuptools # vendors packaging, see above
2424
spack # success, but mypy-primer hangs processing the output
2525
spark # too many iterations
26-
steam.py # hangs
26+
steam.py # hangs (single threaded)
2727
xarray # too many iterations

crates/ty_python_semantic/src/types.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9026,7 +9026,7 @@ impl<'db> BoundSuperType<'db> {
90269026
// Make sure that the `Type` enum does not grow unexpectedly.
90279027
#[cfg(not(debug_assertions))]
90289028
#[cfg(target_pointer_width = "64")]
9029-
static_assertions::assert_eq_size!(Type, [u8; 16]);
9029+
static_assertions::assert_eq_size!(Type, [u8; 24]);
90309030

90319031
#[cfg(test)]
90329032
pub(crate) mod tests {

fuzz/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ ty_python_semantic = { path = "../crates/ty_python_semantic" }
3030
ty_vendored = { path = "../crates/ty_vendored" }
3131

3232
libfuzzer-sys = { git = "https://github.com/rust-fuzz/libfuzzer", default-features = false }
33-
salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "4818b15f3b7516555d39f5a41cb75970448bee4c" }
33+
salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "d980b9e532edbd0ff8570f8c467f8f0a5f3f97e7" }
3434
similar = { version = "2.5.0" }
3535
tracing = { version = "0.1.40" }
3636

output.txt

Whitespace-only changes.

0 commit comments

Comments
 (0)