Skip to content

Commit 38a3b05

Browse files
authored
[red-knot] mypy_primer: Use upstream repo (#17500)
## Summary Switch to the official version of [`mypy_primer`](https://github.com/hauntsaninja/mypy_primer), now that Red Knot support has been upstreamed (see hauntsaninja/mypy_primer#138, hauntsaninja/mypy_primer#135, hauntsaninja/mypy_primer#151, hauntsaninja/mypy_primer#155). ## Test Plan Locally and in CI
1 parent 37a0836 commit 38a3b05

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

.github/workflows/mypy_primer.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545

4646
- name: Install mypy_primer
4747
run: |
48-
uv tool install "git+https://github.com/astral-sh/mypy_primer.git@add-red-knot-support-v6"
48+
uv tool install "git+https://github.com/hauntsaninja/mypy_primer@ebaa9fd27b51a278873b63676fd25490cec6823b"
4949
5050
- name: Run mypy_primer
5151
shell: bash

crates/red_knot/docs/mypy_primer.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
## Basics
44

5-
For now, we use our own [fork of mypy primer]. It can be run using `uvx --from "…" mypy_primer`. For example, to see the help message, run:
5+
`mypy_primer` can be run using `uvx --from "…" mypy_primer`. For example, to see the help message, run:
66

77
```sh
8-
uvx --from "git+https://github.com/astral-sh/mypy_primer.git@add-red-knot-support" mypy_primer -h
8+
uvx --from "git+https://github.com/hauntsaninja/mypy_primer" mypy_primer -h
99
```
1010

1111
Alternatively, you can install the forked version of `mypy_primer` using:
1212

1313
```sh
14-
uv tool install "git+https://github.com/astral-sh/mypy_primer.git@add-red-knot-support"
14+
uv tool install "git+https://github.com/hauntsaninja/mypy_primer"
1515
```
1616

1717
and then run it using `uvx mypy_primer` or just `mypy_primer`, if your `PATH` is set up accordingly (see: [Tool executables]).
@@ -56,6 +56,5 @@ mypy_primer --repo /path/to/ruff --old origin/main --new my/local-branch …
5656

5757
Note that you might need to clean up `/tmp/mypy_primer` in order for this to work correctly.
5858

59-
[fork of mypy primer]: https://github.com/astral-sh/mypy_primer/tree/add-red-knot-support
60-
[full list of ecosystem projects]: https://github.com/astral-sh/mypy_primer/blob/add-red-knot-support/mypy_primer/projects.py
59+
[full list of ecosystem projects]: https://github.com/hauntsaninja/mypy_primer/blob/master/mypy_primer/projects.py
6160
[tool executables]: https://docs.astral.sh/uv/concepts/tools/#tool-executables

crates/red_knot_python_semantic/resources/primer/good.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
arrow
21
async-utils
32
bidict
43
black
@@ -18,7 +17,6 @@ python-chess
1817
python-htmlgen
1918
rich
2019
scrapy
21-
strawberry
2220
typeshed-stats
2321
werkzeug
2422
zipp

0 commit comments

Comments
 (0)