Skip to content

Commit 5203341

Browse files
committed
add todo
1 parent 7826cfd commit 5203341

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

crates/red_knot_test/src/matcher.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,10 @@ trait UnmatchedWithColumn {
139139
// This is necessary since we only parse assertions lazily,
140140
// and sometimes we know before parsing any assertions that an assertion will be unmatched,
141141
// e.g. if we've exhausted all diagnostics but there are still assertions left.
142+
//
143+
// TODO: the lazy parsing means that we sometimes won't report malformed assertions as
144+
// being invalid if we detect that they'll be unmatched before parsing them.
145+
// That's perhaps not the best user experience.
142146
impl Unmatched for UnparsedAssertion<'_> {
143147
fn unmatched(&self) -> String {
144148
format!("{} {self}", "unmatched assertion:".red())

0 commit comments

Comments
 (0)