remove unnecessary code

Author: mtshiba

crates/ty_python_semantic/src/semantic_index/builder.rs

@@ -504,7 +504,8 @@ impl<'db, 'ast> SemanticIndexBuilder<'db, 'ast> {
 
         if popped_scope.is_eager() {
             self.record_eager_snapshots(popped_scope_id);
-        } else {
+        } else if !popped_scope.kind().is_type_alias() {
+            // Don't record lazy snapshots in a type alias scope, as it is a deferred evaluation context.
             self.record_lazy_snapshots(popped_scope_id);
         }
 

crates/ty_python_semantic/src/semantic_index/scope.rs

@@ -263,6 +263,10 @@ impl ScopeKind {
         matches!(self, ScopeKind::TypeParams | ScopeKind::TypeAlias)
     }
 
+    pub(crate) const fn is_type_alias(self) -> bool {
+        matches!(self, ScopeKind::TypeAlias)
+    }
+
     pub(crate) const fn is_non_lambda_function(self) -> bool {
         matches!(self, ScopeKind::Function)
     }

crates/ty_python_semantic/src/types/infer.rs

@@ -6779,12 +6779,6 @@ impl<'db, 'ast> TypeInferenceBuilder<'db, 'ast> {
                             bindings,
                             SnapshotCompleteness::Complete,
                         ) => {
-                            if place_expr.is_symbol()
-                                && !enclosing_scope_id.is_function_like(db)
-                                && !is_immediately_enclosing_scope
-                            {
-                                continue;
-                            }
                             let place = place_from_bindings(db, bindings).map_type(|ty| {
                                 self.narrow_place_with_applicable_constraints(
                                     place_expr,
@@ -6802,12 +6796,6 @@ impl<'db, 'ast> TypeInferenceBuilder<'db, 'ast> {
                             _,
                             SnapshotCompleteness::Incomplete(_, snapshot),
                         ) => {
-                            if place_expr.is_symbol()
-                                && !enclosing_scope_id.is_function_like(db)
-                                && !is_immediately_enclosing_scope
-                            {
-                                continue;
-                            }
                             considered_definitions =
                                 ConsideredDefinitions::AllReachable(Some(snapshot));
                         }