(fixup) Flip control flow to avoid unnecessary boolean not

maxmynter · maxmynter · commit 7ab4d6c8f567 · 2025-03-30T11:35:59.000-04:00
and satifsy clippy
diff --git a/crates/ruff_linter/src/checkers/noqa.rs b/crates/ruff_linter/src/checkers/noqa.rs
@@ -147,9 +147,7 @@ pub(crate) fn check_noqa(
                             break;
                         }
 
-                        if !seen_codes.insert(original_code) {
-                            duplicated_codes.push(original_code);
-                        } else {
+                        if seen_codes.insert(original_code) {
                             let is_code_used = if is_file_level {
                                 diagnostics
                                     .iter()
@@ -172,6 +170,8 @@ pub(crate) fn check_noqa(
                             } else {
                                 unknown_codes.push(original_code);
                             }
+                        } else {
+                            duplicated_codes.push(original_code);
                         }
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -147,9 +147,7 @@ pub(crate) fn check_noqa(`
`147`	`147`	`break;`
`148`	`148`	`}`
`149`	`149`
`150`		`- if !seen_codes.insert(original_code) {`
`151`		`- duplicated_codes.push(original_code);`
`152`		`- } else {`
	`150`	`+ if seen_codes.insert(original_code) {`
`153`	`151`	`let is_code_used = if is_file_level {`
`154`	`152`	`diagnostics`
`155`	`153`	`.iter()`
`@@ -172,6 +170,8 @@ pub(crate) fn check_noqa(`
`172`	`170`	`} else {`
`173`	`171`	`unknown_codes.push(original_code);`
`174`	`172`	`}`
	`173`	`+ } else {`
	`174`	`+ duplicated_codes.push(original_code);`
`175`	`175`	`}`
`176`	`176`	`}`
`177`	`177`