From<DataclassTransformerParams> for DataclassParams

Author: sharkdp

crates/red_knot_python_semantic/src/types.rs

@@ -364,8 +364,8 @@ impl Default for DataclassParams {
     }
 }
 
-impl DataclassParams {
-    fn from_transformer_params(params: DataclassTransformerParams) -> Self {
+impl From<DataclassTransformerParams> for DataclassParams {
+    fn from(params: DataclassTransformerParams) -> Self {
         let mut result = Self::default();
 
         result.set(

crates/red_knot_python_semantic/src/types/call/bind.rs

@@ -690,8 +690,7 @@ impl<'db> Bindings<'db> {
                             // the argument type and overwrite the corresponding flag in `dataclass_params` after
                             // constructing them from the `dataclass_transformer`-parameter defaults.
 
-                            let mut dataclass_params =
-                                DataclassParams::from_transformer_params(params);
+                            let mut dataclass_params = DataclassParams::from(params);
 
                             if let Some(Some(Type::BooleanLiteral(order))) = callable_signature
                                 .iter()

crates/red_knot_python_semantic/src/types/infer.rs

@@ -1780,7 +1780,7 @@ impl<'db> TypeInferenceBuilder<'db> {
 
             if let Type::FunctionLiteral(f) = decorator_ty {
                 if let Some(params) = f.dataclass_transformer_params(self.db()) {
-                    dataclass_params = Some(DataclassParams::from_transformer_params(params));
+                    dataclass_params = Some(params.into());
                     continue;
                 }
             }