[pylint] Better inference for str.strip (PLE310)

Author: MichaReiser

crates/ruff_linter/src/rules/pylint/mod.rs

@@ -445,7 +445,6 @@ mod tests {
         Rule::RepeatedEqualityComparison,
         Path::new("repeated_equality_comparison.py")
     )]
-    #[test_case(Rule::BadStrStripCall, Path::new("bad_str_strip_call.py"))]
     #[test_case(
         Rule::BadStaticmethodArgument,
         Path::new("bad_staticmethod_argument.py")

crates/ruff_linter/src/rules/pylint/rules/bad_str_strip_call.rs

@@ -187,12 +187,6 @@ pub(crate) fn bad_str_strip_call(checker: &Checker, call: &ast::ExprCall) {
 
     let value = &**value;
 
-    if checker.settings.preview.is_disabled()
-        && !matches!(value, Expr::StringLiteral(_) | Expr::BytesLiteral(_))
-    {
-        return;
-    }
-
     let Some(value_kind) = ValueKind::from(value, checker.semantic()) else {
         return;
     };

crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLE1310_bad_str_strip_call.py.snap

@@ -181,3 +181,30 @@ bad_str_strip_call.py:81:10: PLE1310 String `strip` call contains duplicate char
 82 |
 83 | # Errors: Type inference
    |
+
+bad_str_strip_call.py:85:9: PLE1310 String `strip` call contains duplicate characters
+   |
+83 | # Errors: Type inference
+84 | b = b''
+85 | b.strip(b'//')
+   |         ^^^^^ PLE1310
+86 |
+87 | # Errors: Type inference (preview)
+   |
+
+bad_str_strip_call.py:89:12: PLE1310 String `rstrip` call contains duplicate characters (did you mean `removesuffix`?)
+   |
+87 | # Errors: Type inference (preview)
+88 | foo: str = ""; bar: bytes = b""
+89 | foo.rstrip("//")
+   |            ^^^^ PLE1310
+90 | bar.lstrip(b"//")
+   |
+
+bad_str_strip_call.py:90:12: PLE1310 String `lstrip` call contains duplicate characters (did you mean `removeprefix`?)
+   |
+88 | foo: str = ""; bar: bytes = b""
+89 | foo.rstrip("//")
+90 | bar.lstrip(b"//")
+   |            ^^^^^ PLE1310
+   |