Skip to content

Commit d38a529

Browse files
authored
[airflow] warning airflow....DAG.create_dagrun has been removed (AIR301) (#21093)
1 parent 83a00c0 commit d38a529

File tree

5 files changed

+502
-421
lines changed

5 files changed

+502
-421
lines changed

crates/ruff_linter/resources/test/fixtures/airflow/AIR301_class_attribute.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
)
1111
from airflow.datasets.manager import DatasetManager
1212
from airflow.lineage.hook import DatasetLineageInfo, HookLineageCollector
13+
from airflow.models.dag import DAG
1314
from airflow.providers.amazon.aws.auth_manager.aws_auth_manager import AwsAuthManager
1415
from airflow.providers.apache.beam.hooks import BeamHook, NotAir302HookError
1516
from airflow.providers.google.cloud.secrets.secret_manager import (
@@ -20,6 +21,7 @@
2021
from airflow.secrets.base_secrets import BaseSecretsBackend
2122
from airflow.secrets.local_filesystem import LocalFilesystemBackend
2223

24+
2325
# airflow.Dataset
2426
dataset_from_root = DatasetFromRoot()
2527
dataset_from_root.iter_datasets()
@@ -56,6 +58,10 @@
5658
hlc.add_output_dataset()
5759
hlc.collected_datasets()
5860

61+
# airflow.models.dag.DAG
62+
test_dag = DAG(dag_id="test_dag")
63+
test_dag.create_dagrun()
64+
5965
# airflow.providers.amazon.auth_manager.aws_auth_manager
6066
aam = AwsAuthManager()
6167
aam.is_authorized_dataset()
@@ -96,3 +102,15 @@
96102
# airflow.secrets.local_filesystem
97103
lfb = LocalFilesystemBackend()
98104
lfb.get_connections()
105+
106+
from airflow.models import DAG
107+
108+
# airflow.DAG
109+
test_dag = DAG(dag_id="test_dag")
110+
test_dag.create_dagrun()
111+
112+
from airflow import DAG
113+
114+
# airflow.DAG
115+
test_dag = DAG(dag_id="test_dag")
116+
test_dag.create_dagrun()

crates/ruff_linter/src/rules/airflow/rules/removal_in_3.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,12 @@ fn check_method(checker: &Checker, call_expr: &ExprCall) {
492492
"collected_datasets" => Replacement::AttrName("collected_assets"),
493493
_ => return,
494494
},
495+
["airflow", "models", "dag", "DAG"] | ["airflow", "models", "DAG"] | ["airflow", "DAG"] => {
496+
match attr.as_str() {
497+
"create_dagrun" => Replacement::None,
498+
_ => return,
499+
}
500+
}
495501
["airflow", "providers_manager", "ProvidersManager"] => match attr.as_str() {
496502
"initialize_providers_dataset_uri_resources" => {
497503
Replacement::AttrName("initialize_providers_asset_uri_resources")

crates/ruff_linter/src/rules/airflow/rules/suggested_to_update_3_0.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,10 +288,12 @@ fn check_name(checker: &Checker, expr: &Expr, range: TextRange) {
288288
},
289289

290290
// airflow.model..DAG
291-
["airflow", "models", .., "DAG"] => Replacement::SourceModuleMoved {
292-
module: "airflow.sdk",
293-
name: "DAG".to_string(),
294-
},
291+
["airflow", "models", "dag", "DAG"] | ["airflow", "models", "DAG"] | ["airflow", "DAG"] => {
292+
Replacement::SourceModuleMoved {
293+
module: "airflow.sdk",
294+
name: "DAG".to_string(),
295+
}
296+
}
295297

296298
// airflow.sensors.base
297299
[

0 commit comments

Comments
 (0)