Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate or un-deprecate extend-ignore and extend-unfixable #12014

Open
MichaReiser opened this issue Jun 24, 2024 · 0 comments
Open

Deprecate or un-deprecate extend-ignore and extend-unfixable #12014

MichaReiser opened this issue Jun 24, 2024 · 0 comments
Labels
cli Related to the command-line interface configuration Related to settings and configuration

Comments

@MichaReiser
Copy link
Member

MichaReiser commented Jun 24, 2024

The extend-ignore and extend-unfixable options are documented as deprecated but they're still widely used. @charliermarsh argues that he would add the settings if they didn't exist today (for flake8 compact?).

We should either formally deprecate the CLI options (the configuration options have been deprecated for a while) or un-deprecate the settings.

We could consider defining extend-unfixable as an alias for unfixable and extend-ignore for ignore. Both serde and clap support aliasing. The downside would be that the options don't show up in the CLI and the documentation, but that could also be considered an upside (less redundant information). The only thing that doesn't seem to work with aliasing is that schemars doesn't support it.

@MichaReiser MichaReiser added configuration Related to settings and configuration cli Related to the command-line interface labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface configuration Related to settings and configuration
Projects
None yet
Development

No branches or pull requests

1 participant