Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preview logic for Ruff server #12161

Closed
dhruvmanila opened this issue Jul 3, 2024 · 0 comments · Fixed by #12208
Closed

Update preview logic for Ruff server #12161

dhruvmanila opened this issue Jul 3, 2024 · 0 comments · Fixed by #12208
Assignees
@dhruvmanila
Labels
server Related to the LSP server
Milestone
Ruff Server: Stable

Comments

@dhruvmanila
Copy link
Member

I'm okay merging this but there are at least two follow-ups that are necessary

  • Don't set the --preview flag in ruff-vscode if the server version is >= 0.5. We should do this pre-release to avoid that users will unintentionally opt in the future.
  • I would expect that ruff server --preview works the same as ruff check --preview and ruff format --preview and enables all --preview features (linter and formatter).

I would expect that running ruff server --preview would enable all preview features similar to setting preview = true in the settings.

Originally posted by @MichaReiser in #12053 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
server Related to the LSP server
Projects
None yet
Milestone
Ruff Server: Stable
Development

Successfully merging a pull request may close this issue.

Consider --preview flag for server subcommand astral-sh/ruff
1 participant
@dhruvmanila