Enable installation via cargo

[charliermarsh]

We can't upload to crates.io because we're using an unreleased version of RustPython.

[charliermarsh]

I've asked about publishing Ruff's RustPython fork here: RustPython/RustPython#4179

[youknowone]

Regardless we are ready or not, I want to distribute rustpython-parser before ruff 0.1. Please poke me when you are ready for 0.1. I seriously don't want to block ruff's schedule by our fault.

[charliermarsh]

@youknowone - Thank you, that's really helpful and appreciated.

There are a few PRs I'd need to merge to move off of my RustPython fork (which is largely ahead of main) -- I know you know about some of these, but I'll just enumerate them here for completeness:

• Add end locations to all nodes RustPython/RustPython#4192
• Add expression context parsing RustPython/RustPython#4143
• (Not totally essential) Prefer dquotes over squotes RustPython#3
• Make AST nodes Clone-able RustPython/RustPython#4218

[charliermarsh]

RustPython just cut a new release on crates.io. So the only blocker here is (1) confirming that we want to use the Crate, which might mean we're a little slower to pick up changes from Git; and (2) LibCST is still using my unpublished fork (which just removes pyo3 stuff).

[zanieb]

Hey! I was looking at adding documentation for installation from crates.io then realized it wasn't supported :D

1. Is it feasible to use RustPython from Git for other releases and only publish to crates.io if the published RustPython version has the sufficient changes? Is that worth the trouble?

2. Is this resolved now?

[charliermarsh]

I think there are three blockers here that we'd need to resolve, since, in order to publish to crates.io, we can't have any Git dependencies in the dependency tree:

1. Publish our parser fork as their own crates (https://github.com/astral-sh/RustPython-Parser), e.g., ruff_rustpython_parser or similar.
2. In RustPython (and our fork), remove the Git dependency on unicode_names2.
3. Publish our LibCST fork as its own crate (https://github.com/charliermarsh/LibCST/tree/charlie/ruff).

[zanieb]

Related RustPython/Parser#67

[youknowone]

I'd like to grant publish permission of parser to anyone from Ruff who need it.
I didn't finish unicode_names2 patch to merge it yet. I need to port the implementation to its own phf.

[T-256]

I think all mentioned blockers are gone, Are there any new?

[zanieb]

Yes now that we've resolved the blockers we are considering publishing to crates.io but have not come to a decision yet.

[KGrewal1]

Has there been any update on this (or would cargo install --git https://github.com/astral-sh/ruff ruff work: seems to install but I'm not sure if there's tests I can run to confirm: does seem to be working on code I have)

[charliermarsh]

@KGrewal1 -- cargo install --git https://github.com/astral-sh/ruff ruff should work just fine! I tested it myself too.

[philwo]

We're currently looking into options for a new Python code formatter for Chromium, and while we haven't made any decision yet, Ruff is definitely a favorite. 😊

This issue is a blocker for us, though, as we have a policy that all third-party software has to be mirrored into our internal repository, and tools then have to be built from there using internal infrastructure for security reasons. This would be very easy to setup for me if Ruff and all of its dependencies were published to crates.io, as we have existing automation and processes for importing packages hosted there.

Would you be open to revisit this issue and see if Ruff could be published to crates.io?

[charliermarsh]

Thanks @philwo -- that's cool to hear! We can definitely consider it -- will need to discuss as a team. I assume it's not sufficient to, like, mirror the source distribution that we publish to PyPI, and build wheels from that?