Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress ANN401 for methods annotated with typing_extensions.override #4408

Closed
sirrus233 opened this issue May 12, 2023 · 0 comments · Fixed by #4409
Closed

Suppress ANN401 for methods annotated with typing_extensions.override #4408

sirrus233 opened this issue May 12, 2023 · 0 comments · Fixed by #4409
Labels
bug Something isn't working

Comments

@sirrus233
Copy link

I believe this is a follow-on request from: #3952

Where that discussion landed was that it is reasonable to suppress ARG002 for overridden methods, since you cannot control the method signature. I think it follows that ANN401 should be suppressed as well, since if we cannot control the method signature we also cannot control the types, and it is impossible to narrow or remove Any in such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants