Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autofix error] SyntaxError from RUF010 #4414

Closed
janosh opened this issue May 13, 2023 · 1 comment · Fixed by #4423
Closed

[Autofix error] SyntaxError from RUF010 #4414

janosh opened this issue May 13, 2023 · 1 comment · Fixed by #4423
Labels
bug Something isn't working

Comments

@janosh
Copy link

janosh commented May 13, 2023

Applying ruff --fix (v0.0.267) to this line

file_contents += f"  number {str(d['number'])}\n"

causes

error: Autofix introduced a syntax error. Reverting all changes.

The attempted fix is

pymatgen/io/packmol.py:217:42: RUF010 Use conversion in f-string

Workaround is to manually change to

file_contents += f"  number {d['number']!s}\n"
@JonathanPlasse
Copy link
Contributor

I can work on this.

@charliermarsh charliermarsh added the bug Something isn't working label May 13, 2023
@JonathanPlasse JonathanPlasse mentioned this issue May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RUF010 autofix within f-strings JonathanPlasse/ruff
3 participants
@charliermarsh @JonathanPlasse @janosh