Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpython & other repos as formatting stability check to CI #5355

Closed
konstin opened this issue Jun 25, 2023 · 4 comments
Closed

Add cpython & other repos as formatting stability check to CI #5355

konstin opened this issue Jun 25, 2023 · 4 comments
Assignees
Labels
formatter Related to the formatter

Comments

@konstin
Copy link
Member

konstin commented Jun 25, 2023

We have a script that formats cpython twice and checks that the formatting stays the same, that we only output valid syntax and that we don't panic due to some input. I want to integrate this script into CI to avoid regressions. This also needs documentation on how to run the check locally.

@konstin konstin self-assigned this Jun 25, 2023
@konstin konstin added the formatter Related to the formatter label Jun 25, 2023
@konstin konstin changed the title Add cpython formatting stability check to CI Add cpython & other repos as formatting stability check to CI Jul 10, 2023
@cnpryer
Copy link
Contributor

cnpryer commented Jul 16, 2023

This also needs documentation on how to run the check locally

Is this already solved or is there more that could be helpful to document?

@konstin
Copy link
Member Author

konstin commented Jul 16, 2023

The general way is documented at https://github.com/astral-sh/ruff/blob/main/crates/ruff_python_formatter/README.md#checking-entire-projects. I'm currently working a small but diverse set of projects that we continuously check and will add more instructions once that's done.

I also ran the stability checks with the 3k repo from ruff-usage-aggregate and have to go through all of them and either fix them directly or open issues for each distinct one.

@konstin
Copy link
Member Author

konstin commented Jul 18, 2023

i've posted the initial script in #5828, this ticket is effectively about automating most of the scores from that ticket.

@konstin
Copy link
Member Author

konstin commented Jul 25, 2023

Fixed by #5919

@konstin konstin closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

No branches or pull requests

2 participants