Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trailing end-of-line comments in the measured line width #6771

Closed
Tracked by #6197
MichaReiser opened this issue Aug 22, 2023 · 2 comments · Fixed by #6901
Closed
Tracked by #6197

Include trailing end-of-line comments in the measured line width #6771

MichaReiser opened this issue Aug 22, 2023 · 2 comments · Fixed by #6901
Assignees
Labels
formatter Related to the formatter

Comments

@MichaReiser
Copy link
Member

No description provided.

@MichaReiser MichaReiser added the formatter Related to the formatter label Aug 22, 2023
@cnpryer
Copy link
Contributor

cnpryer commented Aug 26, 2023

I can help look into this, but how is it different from #5630? Are there ever situations where a trailing end-of-line comment isn't handled as a line suffix?

@MichaReiser
Copy link
Member Author

I can help look into this, but how is it different from #5630? Are there ever situations where a trailing end-of-line comment isn't handled as a line suffix?

#5630 is only about adding the reserved_width field to LineSuffix but without changing the formatting yet (always initialise it with 0). This issue is about changing the default to the actual comment with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants