Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused-variable (N806) false positive on non-global type aliases #7068

Closed
DetachHead opened this issue Sep 3, 2023 · 1 comment · Fixed by #7119
Closed

unused-variable (N806) false positive on non-global type aliases #7068

DetachHead opened this issue Sep 3, 2023 · 1 comment · Fixed by #7119
Assignees
@charliermarsh
Labels
bug Something isn't working

Comments

@DetachHead
Copy link 

Foo = int | str # no error


def foo():
    Bar = int | str # error: Variable `Bar` in function should be lowercase
@charliermarsh charliermarsh added the bug Something isn't working label Sep 3, 2023
@charliermarsh
Copy link
Member

We can probably only support avoiding this when marked as Bar: TypeAlias (which I'd recommend).

@charliermarsh charliermarsh self-assigned this Sep 3, 2023
@charliermarsh charliermarsh mentioned this issue Sep 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid triggering N806 on TypeAlias assignments astral-sh/ruff
2 participants
@charliermarsh @DetachHead