Formatter undocumented deviation: add comma after single argument definition

[JonathanPlasse]

Black formatting

def main(
    pickle_path: Path = typer.Argument(
        "network_messages.pickle",
        help="The path of the pickle file that will contain the network messages",
    )
) -> None:
    start_async(launch_network_watcher, pickle_path)

Ruff formatting

def main(
    pickle_path: Path = typer.Argument(
        "network_messages.pickle",
        help="The path of the pickle file that will contain the network messages",
    ),
) -> None:
    start_async(launch_network_watcher, pickle_path)

Ruff 0.0.289 with line-length 100

[MichaReiser]

Interesting find. Black does add a trailing comma if the identifier doesn't fit but not when the type annotation or default value expands over multiple lines.

def main(
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
) -> None:
    start_async(launch_network_watcher, pickle_path)


def main(
    pickle_path: Argument(
        "network_messages.pickle",
        help="The path of the pickle file that will contain the network messages",
    )
) -> None:
    start_async(launch_network_watcher, pickle_path)

This feels a bit inconsistent to me. We'll have to narrow down if this is intentional or not.

[charliermarsh]

I ran into this at one point and I believe I came to the conclusion that it was unintentional and that the inconsistencies were hard to understand.

[charliermarsh]

(I prefer the consistency of our formatting here, personally.)

[charliermarsh]

I find the inconsistency here confusing:

def main(
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,
) -> None:
    start_async(launch_network_watcher, pickle_path)


def main(
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa=1,
) -> None:
    start_async(launch_network_watcher, pickle_path)


def main(
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa: Argument(
        "network_messages.pickle",
        help="The path of the pickle file that will contain the network messages",
    ) = 1
) -> None:
    start_async(launch_network_watcher, pickle_path)

I would vote to leave as-is.

[charliermarsh]

We're marking this as an intentional deviation. Can be closed once it's documented.