Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Static type checker and language server à la Pyright #9820

Closed
matthewlloyd opened this issue Feb 5, 2024 · 2 comments
Closed

Comments

@matthewlloyd
Copy link
Contributor

Ruff subsumed Python linters improving upon their performance by more than an order of magnitude. Amazing.

Then, the Ruff team subsumed Black and isort, again revolutionizing Python developer tools, giving us a fast, well maintained, high quality alternative with excellent documentation. Awesome!

There is just one more tool left in my Python workflow: Pyright. Since introducing static typing to my Python repo, it has become an essential sidekick, with the LSP making for an awesome interactive development experience as part of the VS Code extension, and the command-line static type checker has become an integral part of my pre-commit hook.

There is just one small problem with Pyright: it's not as fast as Ruff! A full Pyright run takes 15.430s on the 60K lines of Python in one of my repos. That can be a long time to wait when committing changes. Ruff check takes 0.068s, and Ruff format takes 0.078s.

This feature request is therefore for the Ruff team to do the obvious thing and implement static type checking to subsume the functionality of Pyright and other similar tools. That would make Ruff a true, all-in-one, complete tool for Python linting, formatting, and type checking - a one-stop shop for writing high quality Python code and the only tool you need in your pre-commit.

@qarmin
Copy link

qarmin commented Feb 5, 2024

Duplicate of #3893

@matthewlloyd matthewlloyd changed the title [Feature Request] Static type checker and language server [Feature Request] Static type checker and language server à la Pyright Feb 5, 2024
@zanieb
Copy link
Member

zanieb commented Feb 10, 2024

Tracking in #3893

@zanieb zanieb closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants