Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python_version != is incorrectly normalized #4910

Closed
charliermarsh opened this issue Jul 9, 2024 · 1 comment · Fixed by #4911
Closed

python_version != is incorrectly normalized #4910

charliermarsh opened this issue Jul 9, 2024 · 1 comment · Fixed by #4911
Assignees
Labels
bug Something isn't working preview Experimental behavior

Comments

@charliermarsh
Copy link
Member

charliermarsh commented Jul 9, 2024

On main, this passes:

assert_normalizes_to(
    "python_version != '3.8' and python_version < '3.10'",
    "python_version < '3.8' and python_version < '3.10' and python_version > '3.8'",
);

But the second term is not equivalent. It should be python_version < '3.10' and (python_version < '3.8' or python_version > '3.8').

@charliermarsh charliermarsh added bug Something isn't working preview Experimental behavior labels Jul 9, 2024
@charliermarsh
Copy link
Member Author

\cc @ibraheemdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview Experimental behavior
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant