Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-build-isolation isn't supported for uv tool #6083

Open
charliermarsh opened this issue Aug 14, 2024 · 5 comments
Open

--no-build-isolation isn't supported for uv tool #6083

charliermarsh opened this issue Aug 14, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@charliermarsh
Copy link
Member

I think the use of OnlySystem for Python discovery means that users can't provide a pre-populated environment for (e.g.) PyTorch.

See, e.g., #1715 (comment).

@charliermarsh charliermarsh added bug Something isn't working preview Experimental behavior labels Aug 14, 2024
@charliermarsh
Copy link
Member Author

Marking as a bug since I assumed it did work.

@zanieb
Copy link
Member

zanieb commented Aug 14, 2024

Hm this is tough, it seems really weird to detect a virtual environment when installing a tool?

@charliermarsh
Copy link
Member Author

Note that this is just the environment used for building. It doesn't need to have access to the virtualenv after the build step.

@zanieb
Copy link
Member

zanieb commented Aug 14, 2024

I guess we can change interpreter lookup when --no-build-isolation is passed, a little weird but better than always doing it.

@charliermarsh
Copy link
Member Author

This might be tricky, we always create a virtualenv for the tool and install into the virtualenv. We'd need to find a way to... give that environment access to the user-provided virtualenv, I think? Like via sitecustomize.py maybe.

@zanieb zanieb removed the preview Experimental behavior label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants