Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UV publish with index name does not read environment credentials #9845

Open
sfriedowitz opened this issue Dec 12, 2024 · 6 comments
Open

UV publish with index name does not read environment credentials #9845

sfriedowitz opened this issue Dec 12, 2024 · 6 comments
Labels
needs-decision Undecided if this should be done

Comments

@sfriedowitz
Copy link

I was very excited to see the functionality with uv publish --index <index> come out in version 0.5.8 with this PR #9694, but I don't think it behaves quite as I expected. It does not appear that publishing reads the UV_INDEX_MYINDEX_USERNAME and UV_INDEX_MYINDEX_PASSWORD for credentials when publishing.

Is this expected behavior? And if so, would it be possible to add support for reading credentials from those existing environment variables?

@charliermarsh charliermarsh added the needs-decision Undecided if this should be done label Dec 13, 2024
@charliermarsh
Copy link
Member

I think it seems reasonable to pass the configuration to the publish URL. What do you think, @konstin @zanieb?

@zanieb
Copy link
Member

zanieb commented Dec 13, 2024

Oh interesting. Do you expect the credentials for publishing to be the same as the ones for reading?

I'd expect them to be used, but I worry a different credential will be required?

@charliermarsh
Copy link
Member

Is the implication that you might want a different environment variable?

@sfriedowitz
Copy link
Author

At least for the private PyPI repository we run in my organization, the publishing and reading credentials are the same.
So it seemed intuitive that the UV_INDEX_ variables would be used.

But perhaps the UV_INDEX variables could be used in the absence of the UV_PUBLISH variables?

@konstin
Copy link
Member

konstin commented Dec 17, 2024

We can add UV_INDEX_ as lowest priority credential source, behind CLI,UV_PUBLISH_ and (if used) the keyring.

@sfriedowitz
Copy link
Author

We can add UV_INDEX_ as lowest priority credential source, behind CLI,UV_PUBLISH_ and (if used) the keyring.

That would be perfect, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-decision Undecided if this should be done
Projects
None yet
Development

No branches or pull requests

4 participants