-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency Resolver Ignores Platform-Specific Version Constraints #9988
Comments
That PR is unrelated -- you're looking for #9711 and the linked PRs. I don't know if we'll support this specific case by default though. If you want to be getting an old version of a package for a platform like Intel macOS (which is no longer supported in new PyTorch versions), you'll likely be required to opt-in in some way. |
@konstin @charliermarsh I noticed your discussion regarding this issue in #9711. I have a suggestion that might help address the problem, although I'm not fully aware of its potential implications. Perhaps you could consider adding an option for the resolver to function similarly to the resolver in the pip interface. |
It's actually plausible that your case could be supported since you're willing to define multiple version constraints. |
Can I ask why you don't do:
|
That’s true, but ideally, I’d prefer if it worked the same way as pip, where a simple
This is for a library I’m working on, and we want to support all PyTorch versions above 1.13. Forcing users to install version 2.3 or higher on some platforms wouldn’t work well since it limits compatibility for no good reason. |
Hello,
I want to bring up an issue again about PyTorch dependency resolution on Intel-based macOS. This follows the discussion in #9515, which I wasn’t able to reopen.
I really appreciate the updates with the
fork-strategy
option and the closure of issues #8686 and #7190, but the main problem I brought up is still there: the dependency resolver enforces a single version of PyTorch across all platforms, even when conditional version constraints are specified inpyproject.toml
.Here’s a minimal example of my configuration:
The expectation here is that the resolver should pick PyTorch version 2.2.2 for Intel MacOS, and a different version (e.g., 2.5.1) for other platforms. However, the current behavior enforces a single version (2.2.2) across all platforms.
I was hoping the introduction of the
fork-strategy
option would address this limitation, but it doesn’t seem to allow opting out of this unified resolution behavior.Would it be possible to consider adding a new
fork-strategy
option (or another mechanism) to handle cases like this? This would allow for platform-specific resolution of dependencies as defined in thepyproject.toml
.The text was updated successfully, but these errors were encountered: