Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cnidarium metrics #1155

Closed
Fraser999 opened this issue Jun 5, 2024 · 1 comment
Closed

Enable cnidarium metrics #1155

Fraser999 opened this issue Jun 5, 2024 · 1 comment
Assignees
@Fraser999

Comments

@Fraser999
Copy link
Contributor

Fraser999 commented Jun 5, 2024 •
edited by sync-by-unito bot
Loading

We should enable metrics in the only penumbra dep of ours which emits them - i.e. cnidarium.

This will require us to:

  • enable the metrics feature
  • call register_metrics after the global metrics registry has been set
  • consider invoking histogram!(STORAGE_GET_RAW_DURATION) and histogram!(STORAGE_NONCONSENSUS_GET_RAW_DURATION) as they do inside their lib (without recording any value) in order to actually register the metrics
@Fraser999 Fraser999 self-assigned this Jun 10, 2024
@Fraser999
Copy link
Contributor Author

Closed via #1248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fraser999 Fraser999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fraser999