Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create newtype for transaction hash #1353

Closed
Fraser999 opened this issue Aug 7, 2024 · 1 comment · Fixed by #1410
Closed

Create newtype for transaction hash #1353

Fraser999 opened this issue Aug 7, 2024 · 1 comment · Fixed by #1410
Assignees
@Fraser999
Labels
tech-debt

Comments

@Fraser999
Copy link
Contributor

Fraser999 commented Aug 7, 2024 •
edited by sync-by-unito bot
Loading

We should create a newtype wrapper struct TransactionHash([u8; 32]).

This will improve type safety and will allow for implementing Display and Debug in terms of base64-encoding the bytes, which in turn will reduce some boilerplate elsewhere and ensure consistency in how the hash is displayed.

┆Issue Number: ENG-698
@ethanoroshiba ethanoroshiba linked a pull request Sep 16, 2024 that will close this issue
feat(proto, core, sequencer)!: add traceability to rollup deposits #1410
Merged
@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Sep 23, 2024 •
edited
Loading

Closed in #1410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fraser999 Fraser999

Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(proto, core, sequencer)!: add traceability to rollup deposits astriaorg/astria
2 participants
@Fraser999 @ethanoroshiba