Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencer: add logic to get Protobuf::full_name for Action enum #1567

Closed
Lilyjjo opened this issue Sep 26, 2024 · 2 comments
Closed

Sequencer: add logic to get Protobuf::full_name for Action enum #1567

Lilyjjo opened this issue Sep 26, 2024 · 2 comments
Labels
closed-stale code-quality core pertaining to the astria-core crate stale

Comments

@Lilyjjo
Copy link
Contributor

Lilyjjo commented Sep 26, 2024 •
edited by sync-by-unito bot
Loading

Currently we have an ActionName trait implemented for the Action enum types, which is subpar because we could be grabbing the name from the wire type themselves. It would be good to add the logic for Protobuf::full_name and remove the ActionName trait.

┆Issue Number: ENG-865
@Lilyjjo Lilyjjo added code-quality core pertaining to the astria-core crate labels Sep 26, 2024
@Lilyjjo Lilyjjo mentioned this issue Sep 26, 2024
Merged
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@joroshiba
Copy link
Member

This issue was closed because it was stale

@joroshiba joroshiba closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-stale code-quality core pertaining to the astria-core crate stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joroshiba @Lilyjjo