You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## Summary
Changed firm block channel to use boxed `ReconstructedBlock`.
## Background
A large error variant lint was triggered when running clippy with Rust
1.83.0 in #1857 due to send errors returning the whole block. Large enum
variants should be avoided because enums are only as small as their
largest variant:
https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant.
Changing the channel to consist of a boxed block instead solves this
problem at its source.
## Changes
- Changed firm block channel to use boxed `ReconstructedBlock` instead
of it being unboxed.
## Testing
Passing all tests.
## Changelogs
No updates needed.
## Breaking Changes
Overridden code freeze since this is a very small, non breaking change
that shouldn't have any bearing since our previous audit.
## Related Issues
closes#1858
We should void having large enum variants as described here: https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
Problem point:
astria/crates/astria-conductor/src/executor/mod.rs
Lines 70 to 90 in 7e00378
┆Issue Number: ENG-1039
The text was updated successfully, but these errors were encountered: