Skip to content

Commit a4dd1ce

Browse files
committed
Merge IC:Caelum-rc4+dev11, sample_app v1.3.0-rc4+dev21
- Remove registration of empty event filters - Update codeql workflow for reusable updates - See <nasa/cFS#505>
2 parents 83824aa + d5d5f52 commit a4dd1ce

File tree

5 files changed

+9
-24
lines changed

5 files changed

+9
-24
lines changed

README.md

+6
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ sample_app is an example for how to build and link an application in cFS. See al
1111

1212
## Version History
1313

14+
### Development Build: v1.3.0-rc4+dev21
15+
16+
- Remove registration of empty event filters
17+
- Update codeql workflow for reusable updates
18+
- See <https://github.com/nasa/cFS/pull/505>
19+
1420
### Development Build: v1.3.0-rc4+dev16
1521

1622
- Update copyright headers

fsw/src/sample_app.c

+1-19
Original file line numberDiff line numberDiff line change
@@ -128,28 +128,10 @@ int32 SAMPLE_APP_Init(void)
128128
strncpy(SAMPLE_APP_Data.PipeName, "SAMPLE_APP_CMD_PIPE", sizeof(SAMPLE_APP_Data.PipeName));
129129
SAMPLE_APP_Data.PipeName[sizeof(SAMPLE_APP_Data.PipeName) - 1] = 0;
130130

131-
/*
132-
** Initialize event filter table...
133-
*/
134-
SAMPLE_APP_Data.EventFilters[0].EventID = SAMPLE_APP_STARTUP_INF_EID;
135-
SAMPLE_APP_Data.EventFilters[0].Mask = 0x0000;
136-
SAMPLE_APP_Data.EventFilters[1].EventID = SAMPLE_APP_COMMAND_ERR_EID;
137-
SAMPLE_APP_Data.EventFilters[1].Mask = 0x0000;
138-
SAMPLE_APP_Data.EventFilters[2].EventID = SAMPLE_APP_COMMANDNOP_INF_EID;
139-
SAMPLE_APP_Data.EventFilters[2].Mask = 0x0000;
140-
SAMPLE_APP_Data.EventFilters[3].EventID = SAMPLE_APP_COMMANDRST_INF_EID;
141-
SAMPLE_APP_Data.EventFilters[3].Mask = 0x0000;
142-
SAMPLE_APP_Data.EventFilters[4].EventID = SAMPLE_APP_INVALID_MSGID_ERR_EID;
143-
SAMPLE_APP_Data.EventFilters[4].Mask = 0x0000;
144-
SAMPLE_APP_Data.EventFilters[5].EventID = SAMPLE_APP_LEN_ERR_EID;
145-
SAMPLE_APP_Data.EventFilters[5].Mask = 0x0000;
146-
SAMPLE_APP_Data.EventFilters[6].EventID = SAMPLE_APP_PIPE_ERR_EID;
147-
SAMPLE_APP_Data.EventFilters[6].Mask = 0x0000;
148-
149131
/*
150132
** Register the events
151133
*/
152-
status = CFE_EVS_Register(SAMPLE_APP_Data.EventFilters, SAMPLE_APP_EVENT_COUNTS, CFE_EVS_EventFilter_BINARY);
134+
status = CFE_EVS_Register(NULL, 0, CFE_EVS_EventFilter_BINARY);
153135
if (status != CFE_SUCCESS)
154136
{
155137
CFE_ES_WriteToSysLog("Sample App: Error Registering Events, RC = 0x%08lX\n", (unsigned long)status);

fsw/src/sample_app.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ typedef struct
8585
char PipeName[CFE_MISSION_MAX_API_LEN];
8686
uint16 PipeDepth;
8787

88-
CFE_EVS_BinFilter_t EventFilters[SAMPLE_APP_EVENT_COUNTS];
89-
CFE_TBL_Handle_t TblHandles[SAMPLE_APP_NUMBER_OF_TABLES];
88+
CFE_TBL_Handle_t TblHandles[SAMPLE_APP_NUMBER_OF_TABLES];
9089

9190
} SAMPLE_APP_Data_t;
9291

fsw/src/sample_app_events.h

-2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,4 @@
3434
#define SAMPLE_APP_LEN_ERR_EID 6
3535
#define SAMPLE_APP_PIPE_ERR_EID 7
3636

37-
#define SAMPLE_APP_EVENT_COUNTS 7
38-
3937
#endif /* SAMPLE_APP_EVENTS_H */

fsw/src/sample_app_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
/* Development Build Macro Definitions */
2929

30-
#define SAMPLE_APP_BUILD_NUMBER 16 /*!< Development Build: Number of commits since baseline */
30+
#define SAMPLE_APP_BUILD_NUMBER 21 /*!< Development Build: Number of commits since baseline */
3131
#define SAMPLE_APP_BUILD_BASELINE \
3232
"v1.3.0-rc4" /*!< Development Build: git tag that is the base for the current development */
3333

0 commit comments

Comments
 (0)