Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(properly) distinguish b/w Array and Slice #1

Open
sbinet opened this issue Jul 2, 2014 · 1 comment
Open

(properly) distinguish b/w Array and Slice #1

sbinet opened this issue Jul 2, 2014 · 1 comment
Assignees
@sbinet

Comments

@sbinet
Copy link
Contributor

sbinet commented Jul 2, 2014

right now, some relatively brittle heuristic is in place to distinguish b/w reflect.Array and reflect.Slice.

we always create a slice by reflection when reading back a FITS file b/c there is no way to programmatically create a reflect.Value which happens to be of type-kind reflect.Array.

properly implement this when reflect.ArrayOf is available.
@sbinet sbinet self-assigned this Jul 2, 2014
@sbinet
Copy link
Contributor Author

sbinet commented Jul 2, 2014

govalue_from_typecode, Column.read and Column.write should be revisited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbinet sbinet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbinet