Refreshing the page does not seem to unregister the connector

[bmatthieu3]

Hi @mbtaylor,

Thank you for providing this very practical and easy to use js API. I am looking to use it in Aladin Lite
I noticed that the client remains in the hub list when I refresh the page https://astrojs.github.io/sampjs/examples/send.html
It disappears when I close the tab but still remain when I refresh the page. I suppose the unload event is not called or it is but a bug happens in the unregister maybe. Is there something I can do to avoid that ?

Thank you very much

[bmatthieu3]

It seems listening to beforeunload properly disconnects the client:

window.addEventListener("beforeunload", (_) => {
    connector.unregister();
});

[mbtaylor]

Hi @bmatthieu3, I'm pleased to hear that you are looking at SAMP connectivity in the fabulous Aladin Lite. It's a long time since I wrote this (which I wasn't expecting to turn into the de-facto standard implementation of SAMP from js), and it is entirely likely that the code is doing something unhelpful or stupid. Since I bet your javascript skills are about 1000x better than mine, it might be best if you can figure out what's going wrong here and try to fix it (if that ends up as a major rework/rewrite I won't complain). But if you're unable or unwilling to that's OK, let me know and I'll have a go at working out what's wrong.