Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash parsing when there's an unrecognized node type #477

Closed
jlaneve opened this issue Aug 18, 2023 · 1 comment · Fixed by #503
Closed

Don't crash parsing when there's an unrecognized node type #477

jlaneve opened this issue Aug 18, 2023 · 1 comment · Fixed by #503
Milestone

Comments

@jlaneve
Copy link
Collaborator

jlaneve commented Aug 18, 2023

Right now, when you add a node type that's not explicitly supported by Cosmos, the parsing fails. While we can work to maintain the list of supported nodes, this list keeps growing and comes from many different sources. For example, the Snowflake-Labs/dbt_constraints package adds a new node type, operation. We can't keep track of all of these things in source code, so we shouldn't fail when there's an unexpected node type.

This is also related to the generator functions issue - if a user wants to do something with node types that aren't explicitly supported, they'd be able to use the generating functions.

@tatiana tatiana added this to the 1.2.0 milestone Sep 18, 2023
@tatiana
Copy link
Collaborator

tatiana commented Sep 18, 2023

This PR should address the problem: #503 (will try to remove it from draft this week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants