Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate box region using MOCpy #356

Closed
camposandro opened this issue Sep 24, 2024 · 3 comments
Closed

Generate box region using MOCpy #356

camposandro opened this issue Sep 24, 2024 · 3 comments

Comments

@camposandro
Copy link
Contributor

camposandro commented Sep 24, 2024 •
edited
Loading

Our current implementation of the box region should be replaced with the one recently provided by MOCpy. See from_zone.
@nevencaplar
Copy link
Member

@camposandro Can you elaborate shortly why the implementation from MOCpy would be preferable to what we already have implemented?

@camposandro
Copy link
Contributor Author

The main benefit is that we would reduce the amount of code needed on our side. When we implemented this feature MOCpy didn't have it just yet so we had to implement all the logic on our own (box_filter).

@camposandro
Copy link
Contributor Author

Closed by #428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
HATS / LSDB
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nevencaplar @camposandro