Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty margin catalog instead of None with from_dataframe #419

Open
2 of 3 tasks
hombit opened this issue Sep 19, 2024 · 1 comment
Open
2 of 3 tasks

Return empty margin catalog instead of None with from_dataframe #419

hombit opened this issue Sep 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@hombit
Copy link
Contributor

hombit commented Sep 19, 2024

Bug report

from_dataframe() should assign empty margin catalog instead of None when margin is empty. Originated from this discussion:
#416 (comment)

It looks like it is the similar to #329

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.
@hombit
Copy link
Contributor Author

hombit commented Nov 19, 2024

A reproducible example

import pandas as pd
from lsdb import from_dataframe

# Fails
assert from_dataframe(pd.DataFrame({'ra': [1.0], 'dec': [1.0]})).margin is not None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

2 participants