Skip to content

Commit b80aaf2

Browse files
authored
Merge pull request #97 from pllim/ape-proposal-number-fifo
APE 1: Number is gone once reserved (naming chaos fix 2)
2 parents 16a1ad6 + 9896678 commit b80aaf2

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

APE1.rst

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,18 @@ author: Perry Greenfield
55

66
date-created: 2013 October 11
77

8-
date-last-revised: 2021 February 26
8+
date-last-revised: 2024 February 5
99

1010
date-accepted: 2013 November 8
1111

1212
type: Process
1313

1414
status: Accepted
1515

16-
revised-by: Lia Corrales, Thomas Robitaille, Erik Tollerud - 2021 February 26 - Added APE modification process
16+
revised-by:
17+
18+
* Lia Corrales, Thomas Robitaille, Erik Tollerud - 2021 February 26 - Added APE modification process
19+
* Pey Lian Lim - 2024 February 5 - Added APE numbering process
1720

1821
Abstract
1922
--------
@@ -84,7 +87,8 @@ doing this.
8487

8588
Following a discussion on astropy-dev, the proposal should be submitted as a
8689
pull request to astropy-APEs with the name APE<n>.rst where <n> is an
87-
appropriately assigned number. The draft must use the APEtemplate.rst file.
90+
appropriately assigned number (i.e., not already an accepted/proposed/rejected APE).
91+
The draft must use the APEtemplate.rst file.
8892
That a formal proposal has been submitted as a PR should be announced to the
8993
astropy-dev list.
9094

@@ -191,4 +195,5 @@ The coordinating committee thought it was a honking great idea.
191195
Previous versions of this APE
192196
-----------------------------
193197

194-
* 2013-11-08 [`DOI <http://doi.org/10.5281/zenodo.1043886>`_] [`GitHub <https://github.com/astropy/astropy-APEs/blob/42951733ac42c0ea178d8df30705274a43c93091/APE1.rst>`_]
198+
* 2013-11-08 [`DOI <http://doi.org/10.5281/zenodo.1043886>`_] [`GitHub <https://github.com/astropy/astropy-APEs/blob/42951733ac42c0ea178d8df30705274a43c93091/APE1.rst>`_]
199+
* 2021-03-09 [`GitHub <https://github.com/astropy/astropy-APEs/commit/f2afc2ec72575d3c592b3a5c6257117b07b5b755>`_]

README.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ Finalizing APEs
148148
^^^^^^^^^^^^^^^
149149

150150
The final decision on accepting or rejecting APEs lies with the Astropy
151-
Coordination Committee. Once the community discussion on the APE has wound
151+
Coordination Committee (CoCo). Once the community discussion on the APE has wound
152152
down, the committee discusses the APE and makes a final decision on acceptance
153153
or rejection. One of the committee members should then:
154154

@@ -158,7 +158,7 @@ or rejection. One of the committee members should then:
158158
#. Update the "date-last-revised" to the day of merging and "status" to
159159
"Accepted" or "Rejected".
160160
#. If necessary, rename the APE file to be ``APE##.rst``, where ## is the next
161-
free number on the list of APEs.
161+
free number on the list of APEs. Only do this if there is a conflict.
162162
#. Leave a brief comment in the PR indicating the result.
163163
#. Merge the PR with the above changes.
164164
#. If the APE was accepted then continue with the remaining steps, otherwise
@@ -198,7 +198,7 @@ or rejection. One of the committee members should then:
198198
Updating APEs
199199
^^^^^^^^^^^^^
200200

201-
In the cases where an updated APE requires updating (e.g. references to a new
201+
In the cases where an updated APE requires updating (e.g., references to a new
202202
APE that supercedes it, clarifying information that emerges after the APE is
203203
accepted, etc.), changes can be made directly via PR, but the
204204
"date-last-revised" should be updated in the APE. Additionally, the Zenodo entry

0 commit comments

Comments
 (0)