Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing AngleOrPixelScalarQuantity to ScalarAngleOrPixel #1335

Closed
ysBach opened this issue Apr 24, 2022 · 2 comments
Closed

Changing AngleOrPixelScalarQuantity to ScalarAngleOrPixel #1335

ysBach opened this issue Apr 24, 2022 · 2 comments

Comments

@ysBach
Copy link
Contributor

ysBach commented Apr 24, 2022

I recently found AngleOrPixelScalarQuantity is removed (d61630e).

This made my package to fail when I tried to import it (I used AngleOrPixelScalarQuantity to make custom aperture classes), so I need a fix.

Will everything be fine if I change AngleOrPixelScalarQuantity to ScalarAngleOrPixel, or do I need more?

@ysBach
Copy link
Contributor Author

ysBach commented Apr 24, 2022

Oh I have just found there are more changes in the internal API (_shape_params, etc)...

@larrybradley
Copy link
Member

@ysBach Yes, you can simply replace AngleOrPixelScalarQuantity with ScalarAngleOrPixel. These descriptor classes (and also _shape_params) aren't part of the "public" user-facing API, so these changes aren't in the change log or undergo a deprecation period. I don't think very many people have made custom aperture classes. In fact, you are the first person I've heard to do this. Sorry for any disruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants