Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Management Improvements and Clean-up #14

Merged
merged 6 commits into from
Jan 23, 2019
Merged

Conversation

JWhitleyWork
Copy link

This PR not only contains significant clean-up and linting but also improves memory management by using a smart pointer for handling the Kvaser handle. However, many of the linter changes require API-breaking changes such as moving the sourced location of the header file and changing method names to conform to ROS C++ standards. This will require some testing from @rgunjala93 (and/or others) to verify that no additional memory leaks or performance problems have been created. Rinda - please give us an update once this has been tested on at least a couple of devices for a few hours for stability.

Copy link
Contributor

@rgunjala-as rgunjala-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds okay. Ran this for a couple hours to read CAN frames from a sensor at my desk, did not see any problems.

@Daniel-Stanek Daniel-Stanek merged commit 1a8db0a into master Jan 23, 2019
@Daniel-Stanek Daniel-Stanek deleted the memory-management branch January 23, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants