Memory Management Improvements and Clean-up #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR not only contains significant clean-up and linting but also improves memory management by using a smart pointer for handling the Kvaser handle. However, many of the linter changes require API-breaking changes such as moving the sourced location of the header file and changing method names to conform to ROS C++ standards. This will require some testing from @rgunjala93 (and/or others) to verify that no additional memory leaks or performance problems have been created. Rinda - please give us an update once this has been tested on at least a couple of devices for a few hours for stability.