Default launch file to output to screen. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWhitleyWork
requested review from
Daniel-Stanek,
rgunjala-as,
srustanAStuff and
jurlaubAStuff
Daniel-Stanek
approved these changes
May 16, 2019
srustanAStuff
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would default the
kvaser_interface.launchfile to have thekvaser_interfacenode output it's data to the screen, rather than hiding it when used in other launch files. This is very useful for troubleshooting and general use to make sure that the correct hardware ID, circuit ID, and bitrate were accepted by the driver on launch.