Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JSON schema validation #4

Open
PeeHaa opened this issue Oct 4, 2019 · 1 comment
Open

Implement JSON schema validation #4

PeeHaa opened this issue Oct 4, 2019 · 1 comment
Labels

Comments

@PeeHaa
Copy link
Collaborator

PeeHaa commented Oct 4, 2019

Currently the JSON schema validation is broken and disabled (because broken).

I tried working with opis/json-schema, but I cannot get it to play nice.

Implement JSON validation based on JSON schema. The validation library used must at least support draft-7.

The idea is that plugins can call \AsyncBot\Core\Http::requestJson() with a schema to validate against.

An example of an implementation is done in the IMDB plugin:

@PeeHaa PeeHaa added the r11-hf label Oct 4, 2019
@mega6382
Copy link
Contributor

mega6382 commented Oct 8, 2019

I will look into this, I have mostly only done json schema validation in TypeScript(node.js), but I try to see what I can do here. but if someone has more experience with this, then please be sure to step in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants